Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit a snag trying Testcontainers Cloud Desktop for the first time with Java on Windows due to the line endings of the Maven Wrapper script on a fresh clone. On Windows,
core.autocrlf
defaults totrue
, butmvnw
needs to haveLF
line endings andmvnw.cmd
needs to haveCRLF
line endings, regardless of platform. Up until Maven Wrapper 3.3.1, it was also the case that.mvn/wrapper/maven-wrapper.properties
needed to haveLF
line endings regardless of platform, in order to validate the distribution and wrapper SHA-256 sums on Windows. This PR fixes the all the issues at once by adding.gitattributes
and upgrading Maven Wrapper to v3.3.2. Note that newer versions of Maven Wrapper don't even require the wrapper JAR or downloader source files.This is my onboarding experience using Git Bash on Windows:
And here is how it worked out after adding
.gitattributes
and upgrading Maven Wrapper to v3.3.2:These are the commands I used to generate the changes:
Closes #21.