Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Buffer-style message logging as an alternative to database message logging #131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

in1tiate
Copy link
Member

Should help save space in the long run, and can quell privacy concerns where user message storage is concerned. Long overdue (read: i wrote 90% of this and then forgot about it for months) refactor of #123.

@in1tiate in1tiate requested review from oldmud0 and Crystalwarrior and removed request for oldmud0 December 13, 2020 17:52
@oldmud0
Copy link
Member

oldmud0 commented Dec 13, 2020

Hmmm. I wonder if this is a better approach compared to pruning the database to keep it within either 250 entries or thirty minute's worth of entries, whichever is less. If one keeps it in the database, any queries made against the log can stay unified as part of the database API.

@in1tiate
Copy link
Member Author

in1tiate commented Jan 9, 2021

The idea with keeping the buffer in memory is privacy - users can be assured that their messages will only be stored if a problem arises (as the buffer is only accessible via mod call), and they will otherwise be pushed out of the buffer and vanish into the ether.

@oldmud0
Copy link
Member

oldmud0 commented Jan 9, 2021

It's possible to direct IC logging to an in-memory SQLite database :memory:. Again it's not a good idea to duplicate functionality.

@in1tiate
Copy link
Member Author

Okay but I don't know how to do that so it doesn't exist

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants