Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poster Refactor + TCAF GPS Tags #20278

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Poster Refactor + TCAF GPS Tags #20278

wants to merge 11 commits into from
+729 −185

Conversation

Ben10083
Copy link
Contributor

  • TCAF Corvette given GPS tags and posters for recruitment
  • In process ballooned into major poster refactoring, replacing global list with singletons and adding defined poster subtypes for mappers
  • All defined posters switched to subtype equivalent

Held of on placing any posters in Horizon, as that would be best for a seperate PR if I ever do that

We also might need better names for some of these posters.

@Ben10083 Ben10083 changed the title Poster Refactor Poster Refactor + TCAF GPS Tags Dec 19, 2024
@github-actions github-actions bot added 🗺️ Mapping - Horizon The PR touches the Horizon map files. 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. 🗺️ Mapping - Event The PR touches event map files. labels Dec 19, 2024
DreamySkrell
DreamySkrell requested changes Dec 23, 2024
View reviewed changes
code/__HELPERS/global_lists.dm Show resolved Hide resolved
code/game/objects/effects/decals/contraband.dm Outdated Show resolved Hide resolved
@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazelrat hazelrat hazelrat approved these changes

@NonQueueingMatt NonQueueingMatt Awaiting requested review from NonQueueingMatt NonQueueingMatt is a code owner

@alsoandanswer alsoandanswer Awaiting requested review from alsoandanswer alsoandanswer is a code owner

@DreamySkrell DreamySkrell Awaiting requested review from DreamySkrell DreamySkrell is a code owner

Assignees
No one assigned
Labels
🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. 🗺️ Mapping - Event The PR touches event map files. 🗺️ Mapping - Horizon The PR touches the Horizon map files. Review Required Sprites Adds new or changes existing sprites.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ben10083 @hazelrat @DreamySkrell @BotBOREALIS