I've covered wars, you know: Press camera drone & microphone changes #20289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2024 02:45
|
!review |
hazelrat
approved these changes
Dec 23, 2024
FluffyGhoster
requested changes
Dec 23, 2024
Comment on lines
+148
to
150
| if(!is_contact_area(get_area(C)) && !LAZYISIN(C.network, NETWORK_NEWS)) | ||
| to_chat(user, SPAN_NOTICE("This camera is too far away to connect to!")) | ||
| return FALSE |
There was a problem hiding this comment.
does this respect overmap distance?
so you can't transmit from offship to horizon when they're on opposite ends of the overmap
There was a problem hiding this comment.
I don't believe so and I'm not sure how to go about implementing that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog. These changes are to hopefully both allow the Journalist to feel more fulfilled, especially during Odyssey rounds, as well as to let the Journalist have a one-on-one conversation broadcasted to the Entertainment channel without capturing everyone else's voice in range.