Merge pull request #59 from sebastianswms/conversions

feat: Add conversion metrics to campaign_performance.
AutoIDM · Jul 28, 2023 · 386fa21 · 386fa21
2 parents bdd140d + b95579d
commit 386fa21
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/tap_googleads/schemas/campaign_performance.json b/tap_googleads/schemas/campaign_performance.json
@@ -33,6 +33,9 @@
         "metrics": {
             "type": "object",
             "properties": {
+                "conversions": {
+                    "type": "number"
+                },
                 "clicks": {
                     "type": "string"
                 },

diff --git a/tap_googleads/streams.py b/tap_googleads/streams.py
@@ -280,6 +280,7 @@ def gaql(self) -> str:
                  , campaign.advertising_channel_sub_type
                  , segments.device
                  , segments.date
+                 , metrics.conversions
                  , metrics.impressions
                  , metrics.clicks
                  , metrics.ctr

diff --git a/tap_googleads/tests/test_core.py b/tap_googleads/tests/test_core.py
@@ -7,7 +7,7 @@
 
 
 SAMPLE_CONFIG = {
-    "start_date": datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%d"),
+    "start_date": datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ"),
     "client_id": "12345",
     "client_secret": "12345",
     "developer_token": "12345",

diff --git a/tap_googleads/tests/test_customer_not_found.py b/tap_googleads/tests/test_customer_not_found.py
@@ -11,7 +11,7 @@
 import responses
 
 SAMPLE_CONFIG = {
-    "start_date": datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%d"),
+    "start_date": datetime.datetime.now(datetime.timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ"),
     "client_id": "12345",
     "client_secret": "12345",
     "developer_token": "12345",