Use new Sdr API #4141
Open
Use new Sdr API #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new Sdr API for shader registry fns
|
While the changes work now, since Maya is not using USD 25.05 in any branches, we're likely to break things from time to time in new code, unfortunately. I'm already regularly being tripped up on differences between Maya 2022 up to most recent versions due to differences in USD (and UFE). I'm only saying this to underline we will probably get things wrong and break USD 25.05 until we have an internal build exercising it. |
pierrebai-adsk
approved these changes
Mar 3, 2025
|
That's ok @pierrebai-adsk - I'll fix any breakages as we run into them |
seando-adsk
reviewed
Mar 3, 2025
| @@ -153,7 +153,11 @@ UsdShadeOutput UsdMayaShadingUtil::CreateShaderOutputAndConnectMaterial( | |||
| TfToken outputName = terminalName; | |||
| SdrShaderNodeConstPtr shaderNodeDef = registry.GetShaderNodeByIdentifier(nodeID); | |||
| if (shaderNodeDef) { | |||
| #if PXR_VERSION >= 2025 | |||
There was a problem hiding this comment.
Should be 2505. This caused an error in the preflight since it compiled with your new code.
seando-adsk
requested changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USD 2505 introduces new shader registry API, moving from Ndr to Sdr. This converts maya-usd callsites with API guards