[Pgbelt] Refactor Teardown Command due to DROP EXTENSION wOES #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… outside of full teardown
Bumps [black](https://github.com/psf/black) from 23.10.1 to 23.11.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.10.1...23.11.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build(deps): bump pydantic from 1.10.13 to 2.4.2 Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.13 to 2.4.2. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](pydantic/pydantic@v1.10.13...v2.4.2) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * feat: support for Pydantic v2+ --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Varjitt Jeeva <[email protected]>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
@josephoyomiautodesk please rebase this PR and sign the CLA |
vjeeva
changed the title
|
I have read the CLA Document and I hereby sign the CLA |
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
|
@josephoyomiautodesk please continue to fix up the lint errors |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code needs to be moved to maybe the revoke_pgl function: https://github.com/Autodesk/pgbelt/blob/main/pgbelt/util/pglogical.py#L236-L240.
Then, the revoke_pgl function should maybe run outside of the full teardown code (so it always runs, not just in full mode): https://github.com/Autodesk/pgbelt/blob/main/pgbelt/cmd/teardown.py#L63-L96.