Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding a new Filter model for tables and sequences #686

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eldabaa
Copy link

@eldabaa eldabaa commented Feb 26, 2025

Closes #598

Summary of Changes:

  • New Model: Introduced a new model to handle filtering.
  • Configuration Update: The configuration now includes a FilterConfig type for tables and sequences.
  • Filtering Logic: The apply method is responsible for filtering the results.

Filtering Approach:

  • When to Filter: I propose applying the filtering in the get_config_async method. By doing this, we centralize the function responsible for generating the necessary list of tables and sequences.

Benefits:

  • No need to adjust the current tool logic, as tables and sequences will be rendered as usual.
  • Potentially eliminates redundant code, as there will be no need to apply the filter again elsewhere in the tool.
  • Allows for user alerts if no tables are selected after filtering, before initiating all PG pools and other operations.

Adding logic to apply the filter to the tables and sequences on start and then filling the results on the config
@eldabaa eldabaa requested a review from vjeeva as a code owner February 26, 2025 13:45
Copy link

Thank you for your submission, we really appreciate it. We ask that you sign our Contributor License Agreement before we can accept your contribution.

If you are contributing on behalf of your employer you must fill out our Corporate Contributor License Agreement which can be found here.
If you are contributing on behalf of yourself you must agree to our Individual Contributor License Agreement by reviewing this document and signing it or by replying below a with a comment containing the following text:


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to exclude tables in config
1 participant