MacOS Exporter Dependency Bug #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterBarclay
requested review from
a-crowell,
BrandonPacewic,
PepperLola and
LucaHaverty
as code owners
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
|
I have a few things I want to try out before we merge this one if that's alright. I'll try to be timely about it. |
|
@BrandonPacewic Sure thing. What do you want to try out? |
Trying to fix the subprocess call. |
|
@BrandonPacewic Good luck with that |
BrandonPacewic
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Exporter was failing to install pip package dependencies on MacOS.
Problem
The command to execute the Fusion supplied Python runtime had spaces in it and wasn't wrapped in quotations. I have no idea why this wasn't a problem before.
Solution
Added quotations around failing install and uninstall commands.