Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI elements to their own directory #979

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

PepperLola
Copy link
Contributor

Moved components, modals, panels to src/ui and added path aliases to tsconfig.json and vite.config.ts to reference new paths.

Note

@/components/* -> src/ui/components/*
@/modals/*     -> src/ui/modals/*
@/panels/*     -> src/ui/panels/*

JIRA Issue

added path aliases to reference new components, modals, panels
directories
@PepperLola PepperLola requested a review from a team as a code owner June 18, 2024 23:33
@PepperLola PepperLola requested review from HunterBarclay and BrandonPacewic and removed request for a team June 18, 2024 23:33
@PepperLola PepperLola self-assigned this Jun 18, 2024
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a note about the linting warnings related to fast refresh. We are exporting both functions and components from the same file which breaks fast refresh.

https://github.com/Autodesk/synthesis/blob/541df477edfb0cc623be0842f61689e561abd48e/fission/src/ThemeContext.tsx#L36C1-L42C2

https://github.com/Autodesk/synthesis/blob/541df477edfb0cc623be0842f61689e561abd48e/fission/src/ThemeContext.tsx#L52C1-L52C97

However this is completely unrelated to this PR.

Approved, nice quick and clean!

Edit: Not sure why the code snippet links are not displaying properly 🤔

@BrandonPacewic BrandonPacewic added the ui/ux Relating to user interface, or in general, user experience label Jun 19, 2024
@HunterBarclay
Copy link
Member

@BrandonPacewic We have some other larger issues with fast refresh as well. I added a JIRA bug to the backlog.

@HunterBarclay HunterBarclay merged commit 71a598c into dev Jun 19, 2024
14 checks passed
@HunterBarclay HunterBarclay deleted the jwrigh/1650/ui-dir branch June 19, 2024 05:31
@BrandonPacewic
Copy link
Member

@BrandonPacewic We have some other larger issues with fast refresh as well. I added a JIRA bug to the backlog.

Noted.

@HunterBarclay HunterBarclay restored the jwrigh/1650/ui-dir branch June 21, 2024 03:32
@HunterBarclay HunterBarclay deleted the jwrigh/1650/ui-dir branch June 21, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants