Fix missing author column in wp-admin Posts table #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing for PHP 7.1 will be handled via #1034. They can be ignored for this PR. |
|
This is working for me locally with WP 6.5.2 I think this also resolves #1037 |
|
Love it. I've checked out this branch and it looks like everything works as expected. |
|
This fix has been merged and included in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In CAP 3.6.0, there was a bug that resulted in the author's column missing in wp-admin Posts table. When removing the author dropdown from the quick edit box, the old logic removed post type support for the CAP-registered author taxonomy, which has the same name as the regular author feature. This hard-hitting removal was likely due to the "inconvenient truths" documented in #1036.
The new logic has a more targeted approach - it updates the query args for getting the quick-edit authors list population to only try and include a
0, and this successfully bails the dropdown from being displayed.Fixes #1033.
Fixed #1037.
Closes #1036.
Steps to Test
Use
3.6.0tag and see that the author column is missing. Switch to the PR branch, and see that the author column is present. In both cases, the quick edit does not show the author box.Screenshots
3.6.0
Author column not present (incorrect):
This PR
Author column present (correct):
Quick Edit view does not include author box (correct):
(For comparison, here's what the view would look like with the author box - we don't want this):