Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save previous license upon deactivation #2676

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Save previous license upon deactivation #2676

merged 2 commits into from
Dec 11, 2023

Conversation

mikeyarce
Copy link
Member

@mikeyarce mikeyarce commented Dec 9, 2023 •
edited by github-actions bot
Loading

Fixes #2493

Changes Proposed in this Pull Request

  • When you deactivate a plugin, we'll now store the license in an option!
  • That way, if you decide to activate the plugin again, it will show up in the license box pre-filled so you can activate it easily without needing to find it again.

Testing Instructions

  • Install a plugin separately (not wpjm-addons monorepo)
  • Go to wpjobmanager.com and get a license for it
  • Activate the license in Job Manager > Marketplace > Licenses
  • Deactivate the plugin now!
  • Go back to the Licenses page, see that your license is not active but the old license key is there!
  • Profit.

Release Notes

  • Store previous license when plugin is deactivated for easier reactivation later.
Plugin build for 19f909b
📦 Download plugin zip
▶️ Open in playground

@mikeyarce mikeyarce requested a review from a team December 9, 2023 22:39
thedebian
thedebian approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as advertised.
Left a small code change, apart from that 🚀

@mikeyarce mikeyarce merged commit 9e27664 into trunk Dec 11, 2023
8 checks passed
@mikeyarce mikeyarce deleted the add/save-previous-license branch December 11, 2023 19:03
@yscik yscik added this to the 2.2.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedebian thedebian thedebian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Persist license key
3 participants
@mikeyarce @thedebian @yscik