Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against fatal caused by possibly unset/invalid setting value. #2688

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Guard against fatal caused by possibly unset/invalid setting value. #2688

merged 1 commit into from
Dec 20, 2023

Conversation

pgk
Copy link
Contributor

@pgk pgk commented Dec 20, 2023 •
edited
Loading

Changes Proposed in this Pull Request

  • Guard against invalid setting values on input_multi_enable_expand.

Testing Instructions

  • Try it on a fresh wpjm/addons install.
  • Open settings, and navigate to Email Notifications.
  • No fatals.
  • Tweak email notification settings and check that they are saved.

Release Notes

  • Guard against invalid/unset input_multi_enable_expand value.

New or Updated Hooks and Templates

  • none

Deprecated Code

Screenshot / Video

Plugin build for b5fc672
📦 Download plugin zip
▶️ Open in playground

@pgk pgk self-assigned this Dec 20, 2023
@pgk pgk changed the title Fix fatal caused by possibly corrupt/invalid setting value. Guard against fatal caused by possibly unset/invalid setting value. Dec 20, 2023
@pgk pgk requested a review from a team December 20, 2023 14:50
yscik
yscik approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@pgk pgk merged commit 06e0e2f into trunk Dec 20, 2023
9 checks passed
@pgk pgk deleted the fix/fatal-setting-value-unexpected branch December 20, 2023 16:50
@yscik yscik added this to the 2.2.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yscik yscik yscik approved these changes

Assignees

@pgk pgk

Labels
[Pri] Normal [Type] Bug
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pgk @yscik