Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email multipart boundary #2693

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix email multipart boundary #2693

merged 2 commits into from
Jan 5, 2024

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Jan 4, 2024 •
edited
Loading

Fixes #2684 (comment)

Changes Proposed in this Pull Request

  • Remove the -- prefix so it's not included in the Content-Type header
  • Add --jm-boundary-- to the end
  • Move plain text part first

Testing Instructions

Release Notes

Plugin build for 14e2f09
📦 Download plugin zip
▶️ Open in playground

@yscik yscik self-assigned this Jan 4, 2024
thedebian
thedebian approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked well, sent a comment on Slack about missing end boundary in multipart, but that's not directly related to this change

@yscik yscik changed the title Fix email multipart boundary constant Fix email multipart boundary Jan 5, 2024
@yscik yscik merged commit be029e6 into trunk Jan 5, 2024
8 checks passed
@yscik yscik deleted the fix/multipart-boundary branch January 5, 2024 13:03
@yscik yscik added this to the 2.2.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedebian thedebian thedebian approved these changes

Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yscik @thedebian