Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workaround for Safari action menu focusout #2838

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add workaround for Safari action menu focusout #2838

merged 1 commit into from
Jul 25, 2024

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Jul 22, 2024 •
edited by github-actions bot
Loading

Fixes #2832

Changes Proposed in this Pull Request

  • Add workaround (a small timeout) in the action menu focusout handler for Safari. For some reason the browser is not setting the relatedTarget when a link inside the menu is clicked, causing the menu to close.

Testing Instructions

  • Open the employer dashboard ([job_dashboard]) page in Safari
  • Click on the ⠇ action menu and verify the actions are working

Release Notes

  • Fix job dashboard actions menu in Safari

Screenshots

image
Plugin build for 8181fa9
📦 Download plugin zip
▶️ Open in playground

@yscik yscik requested a review from a team July 22, 2024 19:43
@yscik yscik added this to the 2.4.0 milestone Jul 22, 2024
thedebian
thedebian approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@thedebian thedebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well.

@yscik yscik merged commit 4475fed into trunk Jul 25, 2024
12 checks passed
@yscik yscik deleted the fix/action-menu-focusout branch July 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedebian thedebian thedebian approved these changes

Assignees

@yscik yscik

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Job Dashboard in Safari, Actions Not Performed in Actions Menu
2 participants
@yscik @thedebian