Back to pull request #41401

Account Protection: Add password validation #68759

Sign in to view logs

Triggered via pull request January 30, 2025 18:04

dkmyta

synchronize #41401

add/packages/account-protection-password-validation

Status Failure

Total duration 2m 22s

Artifacts –

linting.yml

on: pull_request

detect changed files

Copied files are in sync

Changelogger use

Changelogger validity

Project structure

PHP Code Sniffer (non-excluded files only)

PHP Compatibility

PHP Code Sniffer (changes to excluded files only)

ESLint (non-excluded files only)

ESLint (changes to excluded files only)

Lint GitHub Actions yaml files

Check linter exclude lists

Lock files are up to date

Monorepo package version refs

Matrix: php_lint

Annotations

11 errors and 6 warnings

Changelogger use

Project packages/account-protection is being changed, but no change file in projects/packages/account-protection/changelog/ is touched! Use `jetpack changelogger add packages/account-protection` to add a change file. Guidelines: https://github.com/Automattic/jetpack/blob/trunk/docs/writing-a-good-changelog-entry.md

Changelogger use

Process completed with exit code 2.

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L17

Missing doc comment for function validate_profile_update() (Squiz.Commenting.FunctionComment.Missing)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L23

Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L23

Processing form data without nonce verification. (WordPress.Security.NonceVerification.Missing)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L35

Missing doc comment for function validation_user_register() (Squiz.Commenting.FunctionComment.Missing)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L45

Missing doc comment for function validate_after_password_reset() (Squiz.Commenting.FunctionComment.Missing)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L55

Missing doc comment for function verify_password_update_nonce() (Squiz.Commenting.FunctionComment.Missing)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L56

$_POST['_wpnonce'] not unslashed before sanitization. Use wp_unslash() or similar (WordPress.Security.ValidatedSanitizedInput.MissingUnslash)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L56

Detected usage of a non-sanitized input variable: $_POST['_wpnonce'] (WordPress.Security.ValidatedSanitizedInput.InputNotSanitized)

PHP Code Sniffer (non-excluded files only)

Process completed with exit code 1.

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L24

This comment is 75% valid code; is this commented out code? (Squiz.PHP.CommentedOutCode.Found)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L30

error_log() found. Debug code should not normally be used in production. (WordPress.PHP.DevelopmentFunctions.error_log_error_log)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L35

Unused function parameter $sanitized_user_login. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L35

Unused function parameter $user_email. (VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L42

error_log() found. Debug code should not normally be used in production. (WordPress.PHP.DevelopmentFunctions.error_log_error_log)

PHP Code Sniffer (non-excluded files only): projects/packages/account-protection/src/class-validation-service.php#L52

error_log() found. Debug code should not normally be used in production. (WordPress.PHP.DevelopmentFunctions.error_log_error_log)