Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow my Jetpack to load for non-admin users #41398

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

jboland88
Copy link
Contributor

@jboland88 jboland88 commented Jan 29, 2025

Proposed changes:

  • This diff updates two endpoints for My Jetpack to use the edit_posts permission in favor of manage_options to allow the My Jetpack page to load properly for more than admin users.

Jetpack product discussion

pbNhbs-cqF-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • To reproduce the original issue, set up a Jetpack test site as an admin user. Connect the Jetpack site.
  • Create a new non-admin account (any role higher than Subscriber)
  • Log in to the Jetpack site as the non-admin user
  • Navigate to My Jetpack
  • The My Jetpack page should show briefly and then disappear. You'll notice API errors in the network console.
  • Now, with this patch applied, try again to load My Jetpack as a non admin.
  • The page should not disappear.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/my-jetpack-for-non-admins branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/my-jetpack-for-non-admins
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

@jboland88 jboland88 marked this pull request as ready for review January 30, 2025 14:15
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Normal labels Jan 31, 2025
@jboland88 jboland88 force-pushed the fix/my-jetpack-for-non-admins branch from 2f12118 to 4cc6acc Compare February 3, 2025 22:06
@jeherve jeherve removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 4, 2025
* allows My Jetpack product endpoints to return for non-admin users

* changelog

* bails during red bubble load if the user does not have manage_options cap (#41444)

* Dont show stats module on my Jetpack if user does not have permissions (#41445)

* Dont show stats module on my Jetpack if user does not have permissions to see it

* a few small updates to stats permission check

* fix conflicts

* Correct a typing change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] My Jetpack [Pri] Normal [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants