-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow my Jetpack to load for non-admin users #41398
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
#41445) * Dont show stats module on my Jetpack if user does not have permissions to see it * a few small updates to stats permission check
2f12118
to
4cc6acc
Compare
* allows My Jetpack product endpoints to return for non-admin users * changelog * bails during red bubble load if the user does not have manage_options cap (#41444) * Dont show stats module on my Jetpack if user does not have permissions (#41445) * Dont show stats module on my Jetpack if user does not have permissions to see it * a few small updates to stats permission check * fix conflicts * Correct a typing change
Proposed changes:
edit_posts
permission in favor ofmanage_options
to allow the My Jetpack page to load properly for more than admin users.Jetpack product discussion
pbNhbs-cqF-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions: