Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: Fix/radio and checkbox alignment #41432

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

enejb
Copy link
Member

@enejb enejb commented Jan 30, 2025

This PR fixes a regression.

Before:

Screenshot 2025-01-30 at 6 25 28 AM

After:

Screenshot 2025-01-30 at 6 25 38 AM

Proposed changes:

  • Fixes the styling of the block

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Load this PR.
  • Add a form block in the block editor.
  • Add the radio and the checkbox blocks, and the multi select checkbox.
  • Notice that the alignment works as expected.

@enejb enejb added [Type] Bug When a feature is broken and / or not performing as intended [Package] Forms labels Jan 30, 2025
@github-actions github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 30, 2025
@simison simison changed the title Form: Fix/radio and checkbox alignemnet Form: Fix/radio and checkbox alignment Jan 30, 2025
@simison
Copy link
Member

simison commented Jan 30, 2025

Alignment on checkbox and spacing on radio still looks weird, but it's fine for another PR too

Screenshot 2025-01-30 at 16 33 53

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Code Coverage Summary

No summary data is avilable for parent commit 895557c, cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, you might try re-running the Tests / Publish coverage data job on this PR once the corresponding job on the trunk commit has succeeded.

Full summary · PHP report · JS report

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/radio-and-checkbox-alignemnet branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/radio-and-checkbox-alignemnet
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@enejb enejb requested a review from a team January 30, 2025 16:21
@enejb enejb added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 30, 2025
@enejb
Copy link
Member Author

enejb commented Jan 30, 2025

The new alignment of checkboxes and radio controls
Screenshot 2025-01-30 at 8 38 22 AM

@simison
Copy link
Member

simison commented Jan 30, 2025

Looking better! Thanks.

The space between two options still feels a tad bit too much — is there some older commit from last week where it was better?

Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think there might be some fine tuning of spacing between elements, but that can be in another PR.

@enejb enejb merged commit 66f8a78 into trunk Jan 30, 2025
62 of 63 checks passed
@enejb enejb deleted the fix/radio-and-checkbox-alignemnet branch January 30, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants