Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make new debugging arg optional to avoid potential fatals #2022

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jan 15, 2025

All Submissions:

Changes proposed in this Pull Request:

Automattic/newspack-plugin#3676 added a new third param to the newspack_recaptcha_verify_captcha filter hook for debugging purposes. However, to avoid potential fatal errors and maintain backwards-compatibility with Newspack Plugin releases older than v5.11.1, this PR makes the new param optional.

How to test the changes in this Pull Request:

A code review should suffice.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Jan 15, 2025
@dkoo dkoo requested a review from a team as a code owner January 15, 2025 21:44
@dkoo dkoo changed the base branch from trunk to release January 15, 2025 21:52
@dkoo
Copy link
Contributor Author

dkoo commented Jan 15, 2025

Thanks, @chickenn00dle! I rebased against release as it's a hotfix (just in case there are sites out there running older release builds). Merging...

@dkoo dkoo merged commit 54df06a into release Jan 15, 2025
10 checks passed
@dkoo dkoo deleted the hotfix/make-new-arg-optional branch January 15, 2025 21:53
matticbot pushed a commit that referenced this pull request Jan 15, 2025
## [4.5.4](v4.5.3...v4.5.4) (2025-01-15)

### Bug Fixes

* make new debugging arg optional to avoid potential fatals ([#2022](#2022)) ([54df06a](54df06a))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants