Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reader-activation): customizable UI text for auth modal #3554

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Nov 18, 2024

All Submissions:

Changes proposed in this Pull Request:

Adds customizable text to the auth UI, which can serve as a place for the publisher to specify additional details about the authorization.

Engagement wizard front-end (one of 3)
image image

To Do

  • labels in the Engagement wizard
  • polishing the UI in the Engagement wizard

How to test the changes in this Pull Request:

  1. View the auth modal UI, confirm nothing has changed
  2. Open the Engagement wizard and observe a new section in the Advanced Settings: "Sign-in UI text"
  3. Fill in the UI text, using text formatting options available
  4. On the front-end, confirm the changes are reflected

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant