fix: replace recaptcha alerts with generic errors #3627
Merged
+51
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
chickenn00dle
added
ras-acc testing
[Status] Needs Review
dkoo
approved these changes
Dec 13, 2024
chickenn00dle
force-pushed
the
fix/handle-recaptcha-errors
branch
from
4ec9675 to
35f34c6
Compare
|
Hey @chickenn00dle, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
chickenn00dle
added a commit
that referenced
this pull request
Dec 16, 2024
This PR replaces the default recaptcha failure alert behavior with generic errors appended to the relevant forms.
chickenn00dle
added a commit
that referenced
this pull request
Dec 16, 2024
This PR replaces the default recaptcha failure alert behavior with generic errors appended to the relevant forms.
dkoo
added a commit
that referenced
this pull request
Dec 17, 2024
* fix(recaptcha): replace alerts with generic errors (#3627) This PR replaces the default recaptcha failure alert behavior with generic errors appended to the relevant forms. * fix(recaptcha): only render on submit * fix: auto retry on recaptcha render failure * fix: add button event listener early * fix(recaptcha): render on focus * fix: specify recaptcha container * fix: account for refresh * fix: restore scroll-into-view when rendering v2 widget * fix: scroll in iframes * fix: refresh v2 widgets on Woo checkout update or error --------- Co-authored-by: dkoo <[email protected]>
matticbot
pushed a commit
that referenced
this pull request
Jan 10, 2025
## [5.10.7-alpha.1](v5.10.6...v5.10.7-alpha.1) (2025-01-10) ### Bug Fixes * **cli:** verify-reader CLI command ([#3660](#3660)) ([c639af7](c639af7)) * **recaptcha:** replace alerts with generic errors ([#3627](#3627)) ([44ef2d2](44ef2d2)) ### Performance Improvements * **data-events:** queue dispatches to execute on shutdown ([#3616](#3616)) ([510a1a0](510a1a0))
|
🎉 This PR is included in version 5.10.7-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jan 14, 2025
# [5.12.0-alpha.1](v5.11.1...v5.12.0-alpha.1) (2025-01-14) ### Bug Fixes * **cli:** verify-reader CLI command ([#3660](#3660)) ([c639af7](c639af7)) * **recaptcha:** replace alerts with generic errors ([#3627](#3627)) ([44ef2d2](44ef2d2)) * remove newspack_corrections_ids meta ([#3675](#3675)) ([dad258b](dad258b)) ### Features * **corrections:** add corrections and clarifications behind feature flag ([#3638](#3638)) ([ea745cf](ea745cf)) ### Performance Improvements * **data-events:** queue dispatches to execute on shutdown ([#3616](#3616)) ([510a1a0](510a1a0))
|
🎉 This PR is included in version 5.12.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jan 20, 2025
# [5.12.0](v5.11.3...v5.12.0) (2025-01-20) ### Bug Fixes * **cli:** verify-reader CLI command ([#3660](#3660)) ([c639af7](c639af7)) * **recaptcha:** replace alerts with generic errors ([#3627](#3627)) ([44ef2d2](44ef2d2)) * remove newspack_corrections_ids meta ([#3675](#3675)) ([dad258b](dad258b)) * **wcs:** migrate-expired-subscriptions handle manual subscriptions ([#3663](#3663)) ([e0f32e8](e0f32e8)) ### Features * **corrections:** add corrections and clarifications behind feature flag ([#3638](#3638)) ([ea745cf](ea745cf)) ### Performance Improvements * **data-events:** queue dispatches to execute on shutdown ([#3616](#3616)) ([510a1a0](510a1a0))
|
🎉 This PR is included in version 5.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1207817176293825/1208950357031079/f
This PR replaces the default recaptcha failure alert behavior with generic errors appended to the relevant forms.
Checkout modal (passes custom error handler when rendering recaptcha):
Registration modal (uses 'default' recaptcha error):
Newsletters subscribe block (uses 'default' recaptcha error):
Registration block (uses 'default' recaptcha error):
How to test the changes in this Pull Request:
Checkout the following Newsletters PR before testing: Automattic/newspack-newsletters#1724
callback: () => errorCallback( 'There was an error with reCAPTCHA. Please try again.' ),. This will trigger an error even when recaptcha is successful for testing purposes.Other information: