Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recaptcha): also verify v2 on checkout #3644

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1200550061930446/1209016713141551/f

This PR makes sure we are also verifying v2 recaptcha response on checkout requests.

How to test the changes in this Pull Request:

  1. Enable recaptcha v2
  2. As a reader go through checkout
  3. There should be no change in behavior, but you can add some logging here to confirm the recaptcha verification is happening in the backend:
    $check = self::verify_captcha();

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Dec 20, 2024
@chickenn00dle chickenn00dle requested a review from a team as a code owner December 20, 2024 16:39
@chickenn00dle chickenn00dle force-pushed the hotfix/recaptcha-on-checkout branch from 731535d to 786e4ce Compare December 20, 2024 17:14
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Dec 20, 2024
@chickenn00dle chickenn00dle requested a review from dkoo December 20, 2024 19:29
@dkoo dkoo mentioned this pull request Dec 21, 2024
6 tasks
dkoo and others added 2 commits January 7, 2025 09:23
* fix: v2 widget in modal checkout

* fix: render v2 widgets on form visible; create utils module
@chickenn00dle chickenn00dle merged commit 88277e9 into release Jan 7, 2025
8 checks passed
@chickenn00dle chickenn00dle deleted the hotfix/recaptcha-on-checkout branch January 7, 2025 16:45
matticbot pushed a commit that referenced this pull request Jan 7, 2025
## [5.10.5](v5.10.4...v5.10.5) (2025-01-07)

### Bug Fixes

* **recaptcha:** verify v2 on all modal checkout requests ([#3644](#3644)) ([88277e9](88277e9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.10.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants