Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update corrections post type slug #3702

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Jan 27, 2025

All Submissions:

Changes proposed in this Pull Request:

See Automattic/newspack-theme#2431

Also:

Test the new "correction type" feature. Both inserting a new correction and updating exiting ones. (existing ones with no value for this field should display Correction)

Verify that the date and time formats match what is set in the site options

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani marked this pull request as ready for review January 27, 2025 15:59
@leogermani leogermani requested a review from a team as a code owner January 27, 2025 15:59
@leogermani leogermani self-assigned this Jan 27, 2025
@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 27, 2025
Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 28, 2025
@leogermani leogermani merged commit 5f100ba into trunk Jan 31, 2025
8 checks passed
@leogermani leogermani deleted the feat/corrections-slug branch January 31, 2025 19:40
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Feb 7, 2025
## [5.13.2-alpha.1](v5.13.1...v5.13.2-alpha.1) (2025-02-07)

### Bug Fixes

* add check for newsletter modal and fix typo ([#3727](#3727)) ([5fdcab6](5fdcab6))
* check for WC as well as WCS ([#3720](#3720)) ([f91803a](f91803a))
* make the cart, checkout pages use shortcodes on install ([#3699](#3699)) ([954e01b](954e01b))
* update corrections post type slug ([#3702](#3702)) ([5f100ba](5f100ba))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.13.2-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants