Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create guest contributors dummy emails #3705

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: create guest contributors dummy emails #3705

merged 1 commit into from
Jan 28, 2025

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Jan 28, 2025 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Fixes a regression added by #3375 that made email for guest contributors not be created.

How to test the changes in this Pull Request:

  1. Create a new guest author and leave the email field empty
  2. Confirm that a dummy email was created for the user

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 28, 2025
@leogermani leogermani self-assigned this Jan 28, 2025
@leogermani leogermani requested a review from a team as a code owner January 28, 2025 20:23
laurelfulford
laurelfulford approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as described!

I also confirmed it fixes the avatar issue with these users when something is assigned using Simple Avatars 🙂

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 28, 2025
@leogermani leogermani merged commit 528712c into release Jan 28, 2025
10 checks passed
@leogermani leogermani deleted the hotfix/guest-contributors-emails branch January 28, 2025 22:09
matticbot pushed a commit that referenced this pull request Jan 28, 2025
@semantic-release-bot
chore(release): 5.12.4 [skip ci]
3b27716 
## [5.12.4](v5.12.3...v5.12.4) (2025-01-28)

### Bug Fixes

* create guest contributors dummy emails ([#3705](#3705)) ([528712c](528712c))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.12.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ronchambers ronchambers mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees

@leogermani leogermani

Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leogermani @matticbot @laurelfulford