Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nav-tabs): do not show native nav tabs in post editor #3706

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jan 28, 2025

All Submissions:

Changes proposed in this Pull Request:

Ensures that the navigation tabs shown in "native" WP-admin-style Newspack dashboard pages are not shown in the post editor. Currently the Newsletters plugin and its pages are the only ones affected.

How to test the changes in this Pull Request:

  1. On epic/ia, add a new Newsletters Ad and edit an existing one. Observe that the "Ads" and "Advertisers" navigation tabs are displayed in both contexts, floating above the block editor content area.
  2. Check out this branch and refresh both "new" and "edit" pages. Confirm that the tabs don't appear anymore.
  3. Confirm that the tabs ARE still shown in the Newsletters Ads and Advertisers dashboard pages, and while editing an Advertiser term.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 28, 2025
@dkoo dkoo self-assigned this Jan 28, 2025
@dkoo dkoo requested a review from a team as a code owner January 28, 2025 21:15
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 28, 2025
@dkoo dkoo merged commit 9dc1f09 into epic/ia Jan 28, 2025
9 checks passed
@dkoo dkoo deleted the fix/tabs-in-post-editor branch January 28, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants