Throw exception for unknown canvas type instead create Image by def…

…ault
Automattic · Mar 21, 2020 · 45021a7 · 45021a7
1 parent 64fb2e5
commit 45021a7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Canvas.cc b/src/Canvas.cc
@@ -114,7 +114,7 @@ NAN_METHOD(Canvas::New) {
       else if (0 == strcmp("svg", *Nan::Utf8String(info[2])))
         backend = new SvgBackend(width, height);
       else
-        backend = new ImageBackend(width, height);
+        return Nan::ThrowRangeError("Unknown canvas type");
     }
     else
       backend = new ImageBackend(width, height);

diff --git a/test/canvas.test.js b/test/canvas.test.js
@@ -260,8 +260,8 @@ describe('Canvas', function () {
     assert.equal(canvas.type, 'pdf')
     var canvas = createCanvas(10, 10, 'svg')
     assert.equal(canvas.type, 'svg')
-    var canvas = createCanvas(10, 10, 'hey')
-    assert.equal(canvas.type, 'image')
+
+    assert.throws(function () { createCanvas(10, 10, 'hey'); }, /RangeError/);
   })
 
   it('Canvas#getContext("2d")', function () {