Framebuffer #1543
Open
Framebuffer #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to review and approve. It's a squashed version with the final code, for references on the development history and commit logs go to the original issue.
…ations Painting operations are `fill()`, `stroke()`, `addPage()`, `putImageData()` and `drawImage()`.
# Conflicts: # .travis.yml # package.json # test/canvas.test.js # test/image.test.js
# Conflicts: # .travis.yml # package.json # test/canvas.test.js # test/image.test.js
# Conflicts: # .travis.yml # package.json # test/canvas.test.js # test/image.test.js
# Conflicts: # package.json
# Conflicts: # package.json
# Conflicts: # package.json
# Conflicts: # src/Canvas.cc
# Conflicts: # src/Canvas.cc
|
Code sync'ed with latest |
# Conflicts: # src/Canvas.cc
# Conflicts: # package.json
Open
|
Can this pull-request be reviewed and merged? :-) |
zbjornson
force-pushed
the
master
branch
2 times, most recently
from
64ed3d8 to
ff0f2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated support for Linux framebuffer. This is build on top of #1540 and is the most complete and complex of the pull-request I've send (basically agregates all the changes), having abstracted ScreenBackend class, updated FbDev support, VSync, double buffering, and also is capable of detect the actual driver features.
Posible improvements would be to try to use double buffering and flip buffers by default (the most performance optimal alternative), and maybe remove the code to notify when paint operations have ocurred, this was from a previous try before being able to enable VSync, but could be useful too, so I left it.
The code is fully working and updated, but maybe there's too much changes to review at once. You can check and merge the other pull-request first one-by-one, so changes on this one will be smaller. You can see the full relationship between all of them at https://github.com/piranna/node-canvas/network.