Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to group button blocks in course page #4160

Open
gikaragia opened this issue Apr 7, 2021 · 0 comments
Open

Allow users to group button blocks in course page #4160

gikaragia opened this issue Apr 7, 2021 · 0 comments

Comments

@gikaragia
Copy link
Contributor

gikaragia commented Apr 7, 2021

Is your feature request related to a problem? Please describe

Currently all button blocks in the course page, are single buttons and cannot be grouped in a similar manner as with core/buttons block or the lesson page.

Describe the solution you'd like

The ideal solution solution would be to be able to add the buttons inside core/buttons. This would give a lot of flexibility to the users and leverage functionality provided by Gutenberg. We could also add a variation of core/buttons which adds all Sensei buttons as inner blocks by default for visibility purposes. Currently there is no direct way to modify the allowed blocks so we should probably consider to do one of the following:

  • Create a new block for each button that would set core/buttons as a parent. This way the block can be added although it is not specified in allowedBlocks.
  • Create a button block variation for each button. Variations would be considered as a core/button block and it would be possible to add them into core/buttons.

Describe alternatives you've considered

  • Create a custom grouping block. Rejected as it seems that it would be best if we can leverage core Gutenberg functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant