Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add View Results block #4155

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Add View Results block #4155

merged 2 commits into from
Apr 7, 2021

Conversation

gikaragia
Copy link
Contributor

Overview

As we have removed the 'View Results' buttons in the latest version of the 'My Courses' page and from course progress bar, there isn't a way for users to add a navigation link to the course results page. This PR tries to deal with this issue.

Changes proposed in this Pull Request

  • Adds a 'View Results' button block in Sensei courses which navigates to the course results page.

Alternatives considered

  • We could possibly look into saving all information in post content to avoid making this a dynamic block. This however would require from users to enclose the block in 'Conditional Content' block, if they want it to be displayed to enrolled users only. Since we didn't follow this approach in other course blocks, I rejected it.
  • I also considered adding the block to the course template, but I think that the template feels a bit cluttered already so I avoid it.

Testing instructions

  • Add the 'View Results' block in a course.
  • With an enrolled user try the block in the frontend.
  • Observe that the description of the block is suitable.

@gikaragia
Copy link
Contributor Author

@gikaragia gikaragia requested a review from a team April 6, 2021 13:02
Copy link
Member

@jom jom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! Yeah, for the template it might take some design work. I wonder if we should figure out how to turn them into a button group? Similar to lesson actions, I suppose.

@gikaragia
Copy link
Contributor Author

I wonder if we should figure out how to turn them into a button group? Similar to lesson actions, I suppose.

Explored this one a bit. I am not sure if supplying them as a group should be the only option as I find it a bit limiting. The ideal way would be for users to be able to add them as a special kind of button in the buttons block. Raised #4160 to track this.

@gikaragia gikaragia merged commit b74835c into master Apr 7, 2021
@jom jom deleted the add/view-results-button branch April 7, 2021 15:17
@donnapep donnapep added this to the 3.10.0 milestone Apr 9, 2021
@donnapep donnapep changed the title Add View Results button Add View Results block Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants