Skip to content

Commit

Permalink
Update the heights of a few dialogs to be larger then the default max…
Browse files Browse the repository at this point in the history
…-height (#2863)

Fixes #2859
Fixes #2861

There had been a max-height set for the default of all dialogs used. This turned out to be too small for a few dialogs.
This increases the height for the Keybindings, Settings, About, and Collaborate dialogs to better fit.
  • Loading branch information
sandymcfadden authored Apr 28, 2021
1 parent e6865f5 commit f1a881e
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion RELEASE-NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
- Fixed displaying extra blank spaces in history screen [#2829](https://github.com/automattic/simplenote-electron/pull/2829), [#2867](https://github.com/automattic/simplenote-electron/pull/2867)
- Fixed to apply selected tag to a new note by default [#2556](https://github.com/automattic/simplenote-electron/pull/2556)
- Fixed spacing on unsynced notes warning message [#2797](https://github.com/automattic/simplenote-electron/pull/2797)
- Fixed cut off issue for dialogs when the window is too small [#2815](https://github.com/automattic/simplenote-electron/pull/2815), [#2834](https://github.com/automattic/simplenote-electron/pull/2834)
- Fixed cut off issue for dialogs when the window is too small [#2815](https://github.com/automattic/simplenote-electron/pull/2815), [#2834](https://github.com/automattic/simplenote-electron/pull/2834), [#2863](https://github.com/automattic/simplenote-electron/pull/2863)
- Fixed unnecessary separators in the Electron builds File and Edit menus when not yet logged in (props @Klauswk) [#2724](https://github.com/automattic/simplenote-electron/pull/2724)

## [v2.9.0]
Expand Down
1 change: 1 addition & 0 deletions lib/components/tab-panels/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
}

.tab-panels__panel {
height: 30.5em;
overflow: auto;
-webkit-overflow-scrolling: touch;
}
Expand Down
2 changes: 2 additions & 0 deletions lib/dialogs/about/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
.dialog {
position: relative;
max-width: 472px;
max-height: calc(100vh - 2rem);

// For overriding theme settings.
// TODO: Improve theme management so this isn't necessary
Expand All @@ -15,6 +16,7 @@

.dialog-content {
padding: 30px 20px 20px;
max-height: calc(100vh - 2rem - 70px);
}

a {
Expand Down
2 changes: 2 additions & 0 deletions lib/dialogs/keybindings/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@
.dialog {
max-width: 500px;
margin: auto;
max-height: calc(100vh - 2rem);
}

.dialog-content {
padding: 10px 20px 20px;
max-height: calc(100vh - 2rem - 56px);
}

ul {
Expand Down
8 changes: 8 additions & 0 deletions lib/dialogs/settings/style.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
.settings {
max-width: 630px;

&.dialog {
max-height: calc(100vh - 2rem);

.dialog-content {
max-height: calc(100vh - 2rem - 56px);
}
}

input[type='radio'] {
cursor: pointer;
}
Expand Down

0 comments on commit f1a881e

Please sign in to comment.