Fix: Avoid write empty state #11
Closed
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khrol
approved these changes
Jan 30, 2025
|
Closing this PR as tap-github use the state management to control the current sync and stream so we can have the special case where we are extracting only non-incremental stream and we need to clear the state with an empty state. The issue with tap-github and target-hdfs will be fixed with this PR Automattic/target-hdfs#22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As this extractor doesn't use the Meltano singer SDK, this PR will not work as the states are manually written.
Manual QA steps
Risks
Rollback steps