Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traefik): build both v2 and v3 #955

Merged
merged 1 commit into from
Nov 11, 2024
Merged

feat(traefik): build both v2 and v3 #955

merged 1 commit into from
Nov 11, 2024

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Nov 11, 2024

Build both Traefik v2 and v3.

  • Because we tagged the original traefik image as latest, we cannot just build v3 and call it latest because this will break old versions of VIP CLI (for Lando, there are incompatible changes in v3);
  • The proposed solution is to keep v2 as latest and tag v3 as v3. Old versions of VIP CLI will continue to use the latest tag, while newer versions will use v3.

@sjinks sjinks self-assigned this Nov 11, 2024
@sjinks sjinks requested a review from a team as a code owner November 11, 2024 15:07
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

Trivy Scan Report

ghcr.io/automattic/vip-container-images/traefik_openssl:latest (alpine 3.20.3)

No vulnerabilities found.

Copy link

Trivy Scan Report

ghcr.io/automattic/vip-container-images/traefik_openssl:v3 (alpine 3.20.3)

No vulnerabilities found.

@sjinks sjinks merged commit 7d28c03 into master Nov 11, 2024
3 checks passed
@sjinks sjinks deleted the multiple-traefiks branch November 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants