Fix the E2E Tests Atomic workflow #10290
Open
+713
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
…to dev/10239-atomic-workflow
Remove log line from Playwright config
…ttic/woocommerce-payments into dev/10239-atomic-workflow
…ttic/woocommerce-payments into dev/10239-atomic-workflow
eduardoumpierre
changed the title
ismaeldcom
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Great team work @eduardoumpierre and @allie500! 🚀 The code changes look good to me, and the action runs without issues.
I'd like to know more about why we need things like ensureCustomerIsLoggedIn or adding articles by its name. Is only due to Atomic? 🤔
|
Hey @ismaeldcom! Thank you for reviewing this PR!
Yes, we encountered some issues where, potentially due to an error, the browser would lose its context. This caused subsequent tests that relied on a specific user context to fail as well. To address this, we implemented that function to mitigate the issue and ensure more reliable test execution.
Could you please clarify this part? |
Sure! I meant this commit. I know that there were some local issues before, but I would like to know if you've found it happening constantly for any reason. I'm just wondering if this solution might lead to the same problem because it relies on the page number. Maybe we can use the slug to navigate directly to the product page. Anyway, not a concern, just curiosity 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10239
Fixes #10260
Changes proposed in this Pull Request
Testing instructions
dev/10239-atomic-workflownpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge