Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Update counts when (de)activating the plugin #1128

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

obenland
Copy link
Member

@obenland obenland commented Jan 6, 2025

Proposed changes:

  • Adds comment count updates to activate/deactivate/delete hooks

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Create Fediverse likes and reposts on a test site.
  • Activate the plugin.
  • Navigate to the comments list and make sure the comment count in the bubbles reflect the amount of text comments.
  • Deactivate the plugin.
  • Navigate to the comments list and make sure the comment count in the bubbles reflect the amount of all comments.

@obenland obenland requested a review from a team January 6, 2025 21:23
@obenland obenland self-assigned this Jan 6, 2025
pfefferle
pfefferle previously approved these changes Jan 10, 2025
@obenland obenland merged commit bca6fd7 into trunk Jan 10, 2025
20 checks passed
@obenland obenland deleted the update/comment-count-deactivation branch January 10, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants