Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WPML post locale #1166

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Conversation

thomas-pike
Copy link
Contributor

Adds WPML compatibility

Proposed changes:

  • Gets the post locale from WPML Multilingual CMS plugin if installed

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Install the WPML Multilingual CMS plugin
  • Publish a post or a translation of an existing post in a language other than the default site language.
  • Check that the activity object is sent out with the expected language.

@github-actions github-actions bot added [Focus] Compatibility Ensuring the plugin plays well with other plugins OSS Citizen labels Jan 15, 2025
@Menrath
Copy link
Contributor

Menrath commented Jan 15, 2025

This is a good first step. Wouldn't it be better to actually have one ActivityPub object, that contains all the languages in the contentMap? The current development in #1148 might be able to make this possible without much overhead.

@mattwiebe
Copy link
Contributor

Thanks for the PR @thomas-pike !

Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice start and we can improve on this.

@pfefferle pfefferle merged commit e703e90 into Automattic:trunk Jan 17, 2025
11 checks passed
@thomas-pike thomas-pike deleted the WPML_compat branch January 19, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Compatibility Ensuring the plugin plays well with other plugins OSS Citizen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants