Use _activityPubOptions
at runtime
#1168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that #1131 breaks stuff on dotcom. But even printing in
wp_head
wasn't good enough, because the scripts were demanding the option to be present at instantiation time. But with a more flexible approach, we can assume that the option will be there at runtime, which is good enough. So I introduced agetOptions
helper to do that.Note that we could get around this by adding proper inline script dependencies to each script in turn, but that was giving problems with the script handles registered through
block.json
viaregister_block_type_from_metadata
. This is why I moved to just outputting it.Testing
All blocks, in editor and the frontend, should keep working properly