-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outbox: Add upgrade script to populate outbox items #1175
base: add/outbox-collection
Are you sure you want to change the base?
Conversation
The risk here is, that all added items will be queued for federation again and because these are quite a lot, it could cause quite some traffic. I think we have to find a way to add historical data without publishing them. |
I was hoping the |
Oh, haven't seen that. True, but this might be only for the moment they were added... the state of the post will still be "pending for federation", so it will be handled at one time... |
da26595 adds a localized version of |
04a4fe4
to
7de214c
Compare
Does it make sense to have some of the functions in the collection, instead of the migration? Should we have dedicated classes for bigger migrations, like for example |
array( | ||
'post_type' => 'ap_outbox', | ||
'posts_per_page' => -1, | ||
'post_status' => 'draft', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use the status to track the process of an item. If an item is added, I would set it to pending
and if it was sent to the fediverse, I would change that to publish
.
Sure, what are you thinking?
At some point I'd like to suggest renaming Migration to Upgrade to align with Core and free up the namespace for any future content migration work. Not sure we need separate classes for upgrade routines (yet). As a matter of fact, I created |
fea0686
to
45b3b2d
Compare
Proposed changes:
activitypub_upgrade
event for async upgrades with locking.add_to_outbox
function that skips any federation considerations.Other information:
Testing instructions: