Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outbox: Use callbacks that can be unhooked. #1188

Open
wants to merge 6 commits into
base: add/outbox-collection
Choose a base branch
from
Open

Outbox: Use callbacks that can be unhooked. #1188

wants to merge 6 commits into from
+219 −33

Conversation

obenland
Copy link
Member

Proposed changes:

  • Moves closures into methods that can be unhooked in tests.

@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Jan 20, 2025
@obenland obenland requested a review from a team January 20, 2025 22:31
@obenland obenland self-assigned this Jan 20, 2025
pfefferle
pfefferle approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your changes, maybe re-check if all cases are handled by unit-tests...

@obenland obenland force-pushed the update/comment-outbox branch from a20c166 to 4acbb7d Compare January 21, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees

@obenland obenland

Labels
Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenland @pfefferle