Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outbox: Fall back to blog author for non-authorized authors #1208

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Outbox: Fall back to blog author for non-authorized authors #1208

merged 6 commits into from
Jan 27, 2025

Conversation

obenland
Copy link
Member

I noticed Outbox items being created when I imported content, including from authors that were not part of the site, and did not have the activtipub cap.

Proposed changes:

  • Skip adding Outbox items for post authors that don't have the cap.
  • Adds unit test to cover that case.

Other information:

  • Have you written new tests for your changes, if applicable?

@obenland obenland added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Jan 23, 2025
@obenland obenland requested a review from a team January 23, 2025 15:58
@obenland obenland self-assigned this Jan 23, 2025
@obenland obenland changed the title Outbox: Don't create items for post from not activitypub-authorized authors Outbox: Fall back to blog author for non-authorized authors Jan 24, 2025
@obenland obenland requested a review from a team January 24, 2025 16:11
@obenland obenland requested a review from pfefferle January 24, 2025 17:24
@obenland obenland merged commit 0dce338 into add/outbox-collection Jan 27, 2025
11 checks passed
@obenland obenland deleted the update/user-cap branch January 27, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees

@obenland obenland

Labels
Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obenland @pfefferle