Anonymous function lint #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfefferle
approved these changes
Sep 25, 2024
|
It's part of Core's PHP Coding Standards. How would you feel about requiring them for this plugin? |
|
@obenland I thought we do that, I have no idea why this was not checked: https://github.com/Automattic/wordpress-activitypub/blob/master/phpcs.xml |
|
So many exceptions! 😱 I'm not sure, it's been a while since I tried setting that up. Maybe all warnings need to elevated to errors for them to be blocked from going in? https://github.com/Automattic/wpcomsh/blob/trunk/phpcs.xml.dist#L35-L36 |
|
Yes, @mattwiebe worked quite some time on it, so that it is compatible with WP.com |
|
Those exceptions are mostly mimicking stuff I found on the wpcom side :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what wpcom demands, apparently :)