Fix callback button

Automattic · Nov 10, 2023 · 424d1bb · 424d1bb
1 parent 9538b0b
commit 424d1bb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/client/my-sites/plans-features-main/index.tsx b/client/my-sites/plans-features-main/index.tsx
@@ -536,6 +536,7 @@ const PlansFeaturesMain = ( {
 	 */
 	const planActionOverrides = useMemo( () => {
 		let actionOverrides: PlanActionOverrides | undefined;
+
 		if ( isInSignup ) {
 			actionOverrides = {
 				loggedInFreePlan: {
@@ -558,12 +559,13 @@ const PlansFeaturesMain = ( {
 						callback: () => {
 							page.redirect( `/add-ons/${ siteSlug }` );
 						},
+						text: translate( 'Manage add-ons', { context: 'verb' } ),
 					},
 				};
 
 				if ( domainFromHomeUpsellFlow ) {
 					actionOverrides.loggedInFreePlan = {
-						...actionOverrides?.loggedInFreePlan,
+						...actionOverrides.loggedInFreePlan,
 						callback: showDomainUpsellDialog,
 						text: translate( 'Keep my plan', { context: 'verb' } ),
 					};
@@ -585,10 +587,10 @@ const PlansFeaturesMain = ( {
 		intentFromProps,
 		isPlanUpsellEnabledOnFreeDomain.isLoading,
 		resolvedSubdomainName.isLoading,
+		translate,
 		domainFromHomeUpsellFlow,
 		siteSlug,
 		showDomainUpsellDialog,
-		translate,
 		canUserManageCurrentPlan,
 		currentPlanManageHref,
 	] );

diff --git a/client/my-sites/plans-grid/components/actions.tsx b/client/my-sites/plans-grid/components/actions.tsx
@@ -300,7 +300,11 @@ const LoggedInPlansFeatureActionButton = ( {
 		}
 
 		return (
-			<Button className={ classes } disabled={ ! planActionOverrides?.currentPlan?.callback }>
+			<Button
+				className={ classes }
+				disabled={ ! planActionOverrides?.currentPlan?.callback }
+				onClick={ planActionOverrides?.currentPlan?.callback }
+			>
 				{ planActionOverrides?.currentPlan?.text }
 			</Button>
 		);