Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Comments" Calypso view with standard WordPress "Comments" view #95622

Closed
Tracked by #98483
richtabor opened this issue Oct 23, 2024 · 9 comments
Closed
Tracked by #98483

Comments

@richtabor
Copy link

richtabor commented Oct 23, 2024

Important

Project thread: pekYwv-4PY-p2
Tracked by #98483

As part of the Untangling Calypso epic, let's remove the custom implementation of the wordpress.com/comments view, in lieu of the standard WordPress wp-admin/comments.php view—for all users.

This will reduce confusion navigating between Calypso and proper WordPress admin.

Requirements

  • Selecting "Comments" from the WordPress or Calypso menu opens the standard WordPress pages view at wp-admin/comments.php
@richtabor richtabor changed the title Replace "Comments" Calypso view with standard WordPress view Replace "Comments" Calypso view with standard WordPress "Comments" view Oct 23, 2024
@tanjoymor
Copy link

Recommendation: Switch to WP Admin for All users / All platforms

Suggestion: Add the ability to Block Users

No other considerations

@Copons
Copy link
Contributor

Copons commented Nov 7, 2024

I don't see any blockers for this. Let's use wp-admin for all users, as recommended!

Considerations

  • Block Users
    • On paper, it's an essential feature. In practice, it's used ~15 times a day (which is a good thing!!).
    • I don't consider this a blocker. However, in the context of this issue, we should do a quick investigation on how we handle comments marked as spam. Maybe we don't explicitly need to block users, but we can simply rely on our regular anti-spam capabilities.

@Aurorum
Copy link
Contributor

Aurorum commented Nov 10, 2024

Calypso also offers the ability to collapse replied comments - not sure how essential that is, but it’s something which I have found useful.

Image

@Copons
Copy link
Contributor

Copons commented Nov 11, 2024

@Aurorum Well noted!

The Calypso comments section has loads of nice UX touches — I shouldn't say so: I was one of the people who originally developed it in... IIRC... the late 1950s. 😅
However, now that we are moving back to wp-admin, we are more concerned about any missing functionality, and even if sometimes painful, UX niceties are not blockers.

@rcrdortiz
Copy link
Contributor

rcrdortiz commented Dec 5, 2024

I don't see any blockers for this. Let's use wp-admin for new users, as recommended!

Considerations

  • Block Users

    • On paper, it's an essential feature. In practice, it's used ~15 times a day (which is a good thing!!).
    • I don't consider this a blocker. However, in the context of this issue, we should do a quick investigation on how we handle comments marked as spam. Maybe we don't explicitly need to block users, but we can simply rely on our regular anti-spam capabilities.

If we want to replicate blocking users from commenting we could do so in the Discussion Options settings page by adding a new section. I will not work on that as part of the main issue since the feature isn't used much and has declined in the past 3 years.

  • /wp-admin/options-discussion.php

Image

@Copons
Copy link
Contributor

Copons commented Dec 9, 2024

@rcrdortiz is the Calypso version simply adding IPs and keywords to these options?

Image

If that's the case, I'd say we are fundamentally covered. Maybe we could mention the change in an "educational" tooltip. 🤔

@mmtr
Copy link
Member

mmtr commented Dec 9, 2024

for new users

We discussed this today and decided that, considering we'll release changes with a holdout test, we want to target all users (new and existing), so I updated the issue summary to reflect that. See p1733745514693799-slack-C04DZ8M0GHW.

@rcrdortiz
Copy link
Contributor

@rcrdortiz is the Calypso version simply adding IPs and keywords to these options?

Image

If that's the case, I'd say we are fundamentally covered. Maybe we could mention the change in an "educational" tooltip. 🤔

Yes, the Calypso version is fundamentally a glorified text field where you can input IPs.

@rcrdortiz
Copy link
Contributor

These changes are now live.

@Copons should we create an enhancement issue for providing IP filtering on wp-admin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants