Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site-context: Open the "Compare email plans" page in site-context layout #98275

Closed
3 tasks
Imran92 opened this issue Jan 13, 2025 · 1 comment · Fixed by #98430
Closed
3 tasks

Site-context: Open the "Compare email plans" page in site-context layout #98275

Imran92 opened this issue Jan 13, 2025 · 1 comment · Fixed by #98430
Assignees
Labels
[Experiment] AI labels added [Feature] Domain Management Tools for managing your site's domain(s). [Feature] Email Integration WordPress.com email including Professional Email, Google integration, forwarding, and inbox. [Feature Group] Emails & Domains Features related to email integrations and domain management.

Comments

@Imran92
Copy link
Contributor

Imran92 commented Jan 13, 2025

The layout of the main pages is implemented under #97911.

In this ticket, we'll just show the already implemented subpage in the domain context in our site context layout from above.

How to reach this page -

  • Enable the feature flag by window.sessionStorage.setItem('flags', 'calypso/all-domain-management')
  • Purchase a blog domain and attach a site with it.
  • Make sure you have no mailboxes for this domain
  • Now go to calypso.localhost:3000/sites and open this site in flyout
  • Scroll to bottom and click on the row to open the domain in site context
  • Click on the compares plan link, the comparison page should open in site-context layout

The page above in both cases opens in the admin layout now. But we need to open it in the same layout as the overview page in site context

Image

Tasks:

  • All buttons, links, completion, cancellation etc takes to pages in correct context
  • Page looks good and similar to this page in the single domain context in all screen sizes
  • The breadcrumb section includes the site when in site-context
@github-actions github-actions bot added [Feature Group] Emails & Domains Features related to email integrations and domain management. [Feature] Domain Management Tools for managing your site's domain(s). [Feature] Email Integration WordPress.com email including Professional Email, Google integration, forwarding, and inbox. labels Jan 13, 2025
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Emails & Domains: The issue focuses on the layout related to email plans and domain management.
  • [Feature] Domain Management: The ticket addresses features that involve managing domains directly in the site-context layout.
  • [Feature] Email Integration: The context suggests the importance of email services and integration related to the domain in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature] Domain Management Tools for managing your site's domain(s). [Feature] Email Integration WordPress.com email including Professional Email, Google integration, forwarding, and inbox. [Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants