Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Disable flaky Twitter embed test #96189

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Nov 8, 2024

Proposed Changes

Disable Twitter embed test.

Why are these changes being made?

This has been increasingly flaky, Twitter's oembed API has been returning 404s for this tweet that definitely exists.

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

This has been increasingly flaky, Twitter's oembed API has been
returning 404s for this tweet that definitely exists.
@anomiex anomiex added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 8, 2024
@anomiex anomiex requested a review from a team November 8, 2024 15:06
@anomiex anomiex self-assigned this Nov 8, 2024
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was going to poke at this to see if a retry would work, but disabling it altogether at this point is better.

Related issue: #96010

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@anomiex
Copy link
Contributor Author

anomiex commented Nov 8, 2024

I tried a retry, but it seems it's flaky enough that it just kept failing.

@anomiex anomiex merged commit 88d7128 into trunk Nov 8, 2024
13 checks passed
@anomiex anomiex deleted the update/e2e-disable-flaky-twitter-embed-test branch November 8, 2024 15:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants