-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created initial structure to My Home Launchpad using the entire home #98372
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~55 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works ✅
I do wonder if we want to create a new version of /home with only the launchpad so the logic doesn't feel tangled with feature flag + params.
We'll control which /home the user gets to through the feature flag at a higher level like here:
context.primary = <CustomerHome key={ siteId } />; |
For example the newsletter flow will redirect over to the new home with launchpad only page.
Would love to hear other thoughts 👂
+1, it feels like we're just gating a small feature, but this is almost a full-page redesign. I'd appreciate splitting it entirely between files. |
We're moving forward with #98476 |
Related to #98348 and #98349
Proposed Changes
home-launchpad
which will add support to the Launchpad using the entire Homehome-launchpad
and thelaunchpadOnly
get parameter is received at the home pageNote: We're adding both the feature flag + URL parameter because in the following iterations, some components will use the feature flag to behave differently and the /home page will use both parameters. With this feature flag we can easily isolate the deliverables of this project.
Why are these changes being made?
Testing Instructions
?flags=home-launchpad&launchpadOnly=true
Pre-merge Checklist