Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics: Handle JSON stringify errors #98467

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jan 16, 2025

Proposed Changes

Handle errors in JSON stringify when debugging analytics.

Why are these changes being made?

Just handling potential errors.

See #98326 and #98464

Testing Instructions

Same as #98326.

@tyxla tyxla added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com. labels Jan 16, 2025
@tyxla tyxla self-assigned this Jan 16, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~26 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-subscriptions        +40 B  (+0.0%)      +26 B  (+0.0%)
entry-stepper              +40 B  (+0.0%)      +26 B  (+0.0%)
entry-main                 +40 B  (+0.0%)      +26 B  (+0.0%)
entry-login                +40 B  (+0.0%)      +26 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/analytics-handle-stringify-errors on your sandbox.

@tyxla tyxla merged commit e7b7075 into trunk Jan 16, 2025
15 checks passed
@tyxla tyxla deleted the update/analytics-handle-stringify-errors branch January 16, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Tracks Metrics & Monitoring Capturing analytics about user behavior on WordPress.com. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants