Theme Details: Show the theme image instead of demo site for a8c themes

[rcrdortiz]

Proposed Changes

We add a check so that themes with the a8c prefix are not counted as WPCom themes. This change avoids rendering the demo site for a8c sites (which don't have demo sites) and loading the preview image instead.

You can find the full context here: p1739377020906119-slack-C04DZ8M0GHW

Why are these changes being made?

• A8C themes are trying to load a demo site that doesn't exist. With these changes, we make sure that the platform continues to work without errors for A8C themes.

Testing Instructions

• Open the Calypso Live link
• Go to: DM me for a specific location
• You should see the preview image instead of an error.

preview-working.mp4

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-133052

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-133052&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-133052&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
theme        +42 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a8c-themes-load-image-instead-of-preview on your sandbox.

[BogdanUngureanu]

LGTM! I haven't tested it because I don't have access to the site, but it shouldn't cause any problems.

[rcrdortiz]

LGTM! I haven't tested it because I don't have access to the site, but it shouldn't cause any problems.

I haven't found any regressions either so it should be safe to deploy.

[dsas]

It feels like isWpcomOnlyTheme would be clearer if renamed. Intuitively a theme starting with a8c/ feels very much like it is going to be a wpcom-only theme.

[rcrdortiz]

It feels like isWpcomOnlyTheme would be clearer if renamed. Intuitively a theme starting with a8c/ feels very much like it is going to be a wpcom-only theme.

We can't use a8c/ themes on WPCom though, which makes isWpcomOnlyTheme semantically correct.
How would you name it?

[dsas]

It feels like isWpcomOnlyTheme would be clearer if renamed. Intuitively a theme starting with a8c/ feels very much like it is going to be a wpcom-only theme.

We can't use a8c/ themes on WPCom though, which makes isWpcomOnlyTheme semantically correct. How would you name it?

The theme is being used on WordPress.com though - the site discussed in slack is a wordpress.com site and is using it. The theme probably will never be used anywhere else in the world but wpcom. isWpcomTheme is presumably true for this theme too.

I'd name it something like usesThemeLiveDemo

[rcrdortiz]

It feels like isWpcomOnlyTheme would be clearer if renamed. Intuitively a theme starting with a8c/ feels very much like it is going to be a wpcom-only theme.

We can't use a8c/ themes on WPCom though, which makes isWpcomOnlyTheme semantically correct. How would you name it?

The theme is being used on WordPress.com though - the site discussed in slack is a wordpress.com site and is using it. The theme probably will never be used anywhere else in the world but wpcom. isWpcomTheme is presumably true for this theme too.

I'd name it something like usesThemeLiveDemo

Changed here:

• Theme Details Page: Improve function naming #99783