Launchpad: Remove unused Badge
#99734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
ciampo
approved these changes
Feb 14, 2025
| const Badge: React.FunctionComponent< BadgeProps > = ( props ) => { | ||
| const className = props.className; | ||
| const type = props.type || 'warning'; | ||
| return <div className={ clsx( `badge badge--${ type }`, className ) }>{ props.children }</div>; |
There was a problem hiding this comment.
It looks like there are a few references to the .badge classname in packages/launchpad/src/checklist-item/style.scss but I assume they're targeting the Badge from @automattic/components, which also happens to use the .badge classname 🤦
- using the
.badgeclassname should be avoided as it breaks style encapsulation - we should definitely improve the classnames and scope them (or obfuscate them), as @mirka also recently reported in another PR
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove the unused
Badgecomponent - seems like it hasn't been used since its creation.Why are these changes being made?
Just cleaning up. Spotted this when I was reviewing yet another instance of a
Badgein #99343.Testing Instructions