Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop app: Beta release for OAuth login #99742

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Feb 13, 2025

Related to #89736 #72754 #55611

Proposed Changes

In #98345 we introduced a new OAuth login flow for the desktop app, but kept it disabled. This PR enables that flow, and issues a new beta release so that these changes can be tested before actually releasing to customers. Please see the description of #98345 for details on the changes that are being introduced.

Why are these changes being made?

Please see the description of #98345.

Testing Instructions

  1. If you already have the WordPress.com Desktop app installed, open it and logout
  2. Download and install the beta app for the system you're testing on (Mac, Linux, Windows)
  3. Set your default browser to the one you'd like to test (Please consider testing with a browser that is not yet marked as checked in the list below)
  4. Open the app
  5. Click "Log in with WordPress.com"
  6. The browser that you set as default in step 3. should open
  7. Go through the authentication flow in the browser
  8. At the end, when you click "Authorize" the app should re-open automatically, and should log you in
  9. If successful, check the corresponding entry in the list below
  • Mac
    • Firefox
    • Chrome
    • Safari
  • Windows
    • Firefox
    • Chrome
    • Edge
  • Linux
    • Firefox
    • Chrome/Chromium

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@psrpinto psrpinto changed the base branch from trunk to fix/always-register-desktop-login-routes February 13, 2025 16:21
@psrpinto psrpinto self-assigned this Feb 13, 2025
Copy link
Collaborator

@wp-desktop wp-desktop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress Desktop CI Failure for job "wp-desktop-mac".

@psrpinto please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

@matticbot
Copy link
Contributor

matticbot commented Feb 13, 2025

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Feb 13, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug desktop/oauth-login on your sandbox.

Base automatically changed from fix/always-register-desktop-login-routes to trunk February 14, 2025 10:03
@psrpinto psrpinto force-pushed the desktop/oauth-login branch from 3bbab0b to 95e3287 Compare February 14, 2025 10:18
@psrpinto psrpinto changed the title Desktop app: Enable the new oauth login flow Desktop app: Beta release for OAuth login Feb 14, 2025
@psrpinto psrpinto force-pushed the desktop/oauth-login branch from 95e3287 to 724bc07 Compare February 14, 2025 11:49
@wp-desktop wp-desktop dismissed their stale review February 14, 2025 11:55

wp-desktop ci passing, closing review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants