Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the URL for "24/7 expert support link" #99755

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dlind1
Copy link
Contributor

@dlind1 dlind1 commented Feb 13, 2025

Proposed Changes

  • Change the URL on /me/developer to properly load the localized version.

Why are these changes being made?

Testing Instructions

  • Using calypso.live or local instance, switch your profile to Spanish, open /me/developer and confirm that the 24/7 expert support / Servicio de soporte especializado ininterrumpido link opens a Spanish article.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@dlind1 dlind1 marked this pull request as ready for review February 13, 2025 18:16
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~9 bytes removed 📉 [gzipped])

name       parsed_size           gzip_size
developer        -12 B  (-0.0%)       -9 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/support-link-for-spanish on your sandbox.

@dlind1 dlind1 requested a review from a team February 13, 2025 19:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 13, 2025
Copy link
Contributor

@jornp jornp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link works well in Spanish, but for other locales I'm getting this "Auto draft" page loaded:

image

Copy link
Contributor

@jornp jornp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Together with 173497-ghe-Automattic/wpcom and disabling caching in the right places, this works well! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants